fix: restore MainActor context for notification observation task#86
Merged
fix: restore MainActor context for notification observation task#86
Conversation
The Task in startObserving() lost its @mainactor context when nonisolated(unsafe) was added to observationTask in 6f0602d. This caused the polling loop to not properly observe changes to the @MainActor-isolated playerService.currentTrack property. Adding @mainactor to the Task closure ensures proper actor isolation, matching the pattern already used in NetworkMonitor. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 task
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in notification observation that was inadvertently broken when nonisolated(unsafe) was added to observationTask to resolve Swift 6 deinit warnings. The fix restores proper actor isolation by adding @MainActor to the Task closure, ensuring the polling loop can correctly observe changes to @MainActor-isolated properties.
Changes:
- Added
@MainActorannotation to the Task closure inNotificationService.startObserving()
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@MainActorannotation to the Task closure inNotificationService.startObserving()nonisolated(unsafe)was added in commit 6f0602dRoot Cause
When
nonisolated(unsafe)was added toobservationTaskto fix Swift 6 deinit warnings, the Task lost its implicit@MainActorcontext inheritance. This caused the polling loop to not properly observe changes to the@MainActor-isolatedplayerService.currentTrackproperty.Fix
Adding
@MainActorto the Task closure ensures proper actor isolation, matching the pattern already used inNetworkMonitor.Test plan
🤖 Generated with Claude Code